Skip to content

add tencentai support to dingdongbot #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2020
Merged

add tencentai support to dingdongbot #7

merged 3 commits into from
May 29, 2020

Conversation

huangaszaq
Copy link
Contributor

This is chat bot based on tencent_ai_plat.

@huangaszaq huangaszaq requested a review from a team as a code owner May 26, 2020 02:56
@huan
Copy link
Member

huan commented May 26, 2020

Please follow the same directory structure from our TS wechaty-getting-started, because we believe that is the best practice for the newcomers who can get to started most easily.

  1. basic
  2. advanced
  3. professional
  4. hird-party

This bot I believe can be put into the professional sub-directory category.

@huangaszaq
Copy link
Contributor Author

@huan Got it. We are completing python-wecahty-getting-started. This bot is created by the way.

@huan
Copy link
Member

huan commented May 26, 2020

Great, and thank you very much for creating the TencentAI class for our Wechaty Python Bot Example, it looks awesome!

wj-Mcat
wj-Mcat previously approved these changes May 28, 2020
Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the directory from examples/tencentaiplat/ to examples/professional/tencentaiplat/ so that we can keep our examples/ root directory as clean as possible for newcomers.

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat wj-Mcat merged commit 3859690 into wechaty:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants